Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mediatek-mt7622: Add support for D-Link EAGLE PRO AI R32 A1 #3332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mediatek-mt7622: Add support for D-Link EAGLE PRO AI R32 A1 #3332

wants to merge 1 commit into from
+10 −0

Conversation

RolandoMagico
Copy link

@RolandoMagico RolandoMagico commented Aug 14, 2024 •
edited
Loading

  • Must be flashable from vendor firmware
    • Web interface
    • TFTP
    • Other: D-Link recovery web interface
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())')
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging)
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
    • When re-adding a device that was supported by an earlier version of Gluon, a
      factory reset must be performed before checking the primary MAC address, as
      the setting from the old version is not reset otherwise.
  • Wired network
    • should support all network ports on the device
    • must have correct port assignment (WAN/LAN)
      • if there are multiple ports but no WAN port:
        • the PoE input should be WAN, all other ports LAN
        • otherwise the first port should be declared as WAN, all other ports LAN
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio
      • Should show activity
    • Switch port LEDs
      • Should map to their respective port (or switch, if only one led present)
      • Should show link state and activity
  • Outdoor devices only:
    • Added board name to is_outdoor_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
  • Cellular devices only:
    • Added board name to is_cellular_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
    • Added board name with modem setup function setup_ncm_qmi to package/gluon-core/luasrc/lib/gluon/upgrade/250-cellular
  • Docs:
    • Added Device to docs/user/supported_devices.rst

@github-actions github-actions bot added 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support labels Aug 14, 2024
@blocktrron
Copy link
Member

Radio LEDs are not working?

@RolandoMagico
Copy link
Author

RolandoMagico commented Aug 16, 2024 •
edited
Loading

Radio LEDs are not working?

Not as I would expect. 2.4G is on by default and it's flickering while there is traffic on 2.4GHz. 5G is off by default and there is also no change during traffic on 5GHz wifi.

Update: also tried to get a defined behavior in OpenWrt using the LED settings, but also no success there.

@blocktrron
Copy link
Member

Sorry for the late reply - if the LEDs are not working, please add the broken flag and remove the device from the documentation. Everything else LGTM.

@RolandoMagico RolandoMagico force-pushed the D-Link_R32 branch 2 times, most recently from cc999d0 to e5077a2 Compare November 18, 2024 17:42
@github-actions github-actions bot removed the 3. topic: docs Topic: Documentation label Nov 18, 2024
@RolandoMagico
Copy link
Author

Sorry for the late reply - if the LEDs are not working, please add the broken flag and remove the device from the documentation. Everything else LGTM.

Done

@Djfe
Copy link
Contributor

Djfe commented Dec 10, 2024

This is pretty much ready to be merged. This device is marked as broken so it won't be backported into the last stable release 2023.2.x. and main's next release is going to be based on OpenWrt 24.10 which was merged a few days ago.
Please help us out and rebase your PR a second time. Then retest the device (due to the new OpenWrt release).

It's likely that the new OpenWrt release (candidate) broke some stuff so that will need fixing anyways so it's only in your interest for this to be tested. (issues that might affect other mt7622 devices as well)
Since OpenWrt adjusted how MAC addresses are loaded (definition is now in the dts as you probably know) please retest whether the primary mac on firstboot is still the mac address which is silkscreened onto the device.

If you don't have the time to do the tests, then please tell us :)

@RolandoMagico
Copy link
Author

RolandoMagico commented Dec 13, 2024 •
edited
Loading

@Djfe: I rebased and built the image. What I saw so far:

  • Primary MAC is correct
  • Wifi LED issue still present
  • Wifi was not working. Also in config mode, there were errors reported when trying to configure wifi:
    image
    image

I'm not an expert in gluon. Do you know if is related to my build setup or it is a general issue?

My build environment:
https://github.com/RolandoMagico/site-ffrgb/tree/R32-Test

Command I used:
make GLUON_TARGETS=mediatek-mt7622 BROKEN=1
Thanks
Roland

@Djfe
Copy link
Contributor

Djfe commented Dec 13, 2024

there were one or two issues fixed very recently
openwrt/openwrt@1be18c6
openwrt/openwrt@00860e4
atleast the first one is essential and wasn't merged into gluon main, yet.
We still have to test lots of stuff around the next OpenWrt release to find bugs like these.

I had the same issue you experienced with the netgear wax206. Thanks for confirming that more device than one are affected.
So it's either the issue above or in some way target related.
Thanks for reporting back.

I'll check on my WAX206 soon (with the fix above)
Once the issue has been cleared I'm going to inform you again over the forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3. topic: hardware Topic: Hardware Support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RolandoMagico @blocktrron @Djfe